java


What is the best way to mock object instantiated inside method under test?


I have the following code and I look for the best way to test it:
public class ClientFactory {
private ConfigurationLoader loader;
public ClientFactory(ConfigurationLoader loader) {
this.loader = loader;
}
public IRest create(String something) {
Configuration config = loader.load(something);
if (magic()) {
return new ClientType1(config);
}
return new ClientType2(config);
}
}
public class ClientType1 implements IRest{
private Configuration config;
public ClientType1(Configuration config) {
this.config = config;
}
public Something doGetRequest(Long id) {
WebClient client = getHttpClient();
return client.get();
}
private WebClient getHttpClient() {
WebClient client = new WebClient();
client.setSchema(config.getSchema());
client.setHostname(config.getHostname());
client.setPort(config.getPort());
// and so on ....
return client;
}
}
I would like to test the interaction/behaviour between ConfigurationLoader and ClientType1.getHttpClient methods. From one side I think it is good idea, testing interaction between objects, from the other side, hmmm I test setters and getters - boring, no business logig is involved here. Which one is more true?
Mock of configuration object can be easily transferred into ClientType1 when it is instantiated, mocking the 'new WebClient()' seems to be the problem. I thought about:
public class ClientType1 implements IRest{
private Configuration config;
private WebClient client; // this will be replaced by mock
public ClientType1(Configuration config) {
this.config = config;
webClient = new WebClient();
}
.....
private Client getHttpClient() {
client.setSchema(config.getSchema());
....
return client;
}
}
and use PowerMock to replace private WebClient client by mock, but I am not sure it is java way. Any guidelines/suggestions?
As you have found, the new keyword makes unit testing difficult. I suggest avoiding it. I think your problem here is more of a design problem. Objects should not configure themselves. When you design an object, think about what its true dependencies are. IMO the true dependency of the ClientType1 is a WebClient or a pool of WebClient not a Configuration. IMO the true dependency of ClientFactory is a Configuration not a String.
I would redesign like so:
interface ClientFactory {
IRest create(Configuration config);
}
public class DefaultClientFactory implements ClientFactory {
private final ClientFactory magicClientFactory;
private final ClientFactory otherClientFactory;
public DefaultClientFactory(ClientFactory magicClientFactory, ClientFactory otherClientFactory) {
this.magicClientFactory = magicClientFactory;
this.otherClientFactory = otherClientFactory;
}
public IRest create(Configuration config) {
if (magic()) {
return magicClientFactory.create(config);
} else {
return otherClientFactory.create(config);
}
}
}
interface WebClientFactory {
WebClient create(Configuration config);
}
public class DefaultWebClientFactory implements WebClientFactory {
public WebClient create(Configuration config) {
WebClient client = new WebClient();
client.setSchema(config.getSchema());
client.setHostname(config.getHostname());
client.setPort(config.getPort());
return client;
}
}
public class ClientType1Factory implements ClientFactory {
private final WebClientFactory webClientFactory;
public ClientType1Factory(WebClientFactory webClientFactory) {
this.webClientFactory = webClientFactory;
}
public IRest create(Configuration config) {
return new ClientType1(webClientFactory.create(config));
}
}
public class ClientType1 implements IRest{
private final WebClient webClient;
public ClientType1(WebClient webClient) {
this.webClient = webClient;
}
public Something doGetRequest(Long id) {
return webClient.get();
}
}
Using this design you can successfully unit test each and every class defined without resorting to advanced features of PowerMock. You can unit test ClientType1 by passing in a mock WebClient. You can also test your factories by passing in different configurations and checking if the created object is what you expect. Further the code is less coupled, more flexible, and each class has a single responsibility.

Related Links

Ignore code while testing a function using junit
Unirest post method sending duplicate files while using multipart request
How to use Spannable in SurfaceView
wsdl2java - using cxf-codegen-plugin - multiple schema on one wsdl file
Converting String of 1's and 0's to a binary file
Can't connect to SQL server from Android studio
Looking for an efficient file caching system
Android main thread stalls when exiting ASyncTasks
How to run a web project using sysdeo Tomcat launcher plugin?
Android Studio: Github commit warning - Access can be package-private
Spring creating a bean dependant on other beans [duplicate]
Using a http proxy with Apache Camel's http4 endpoint
revalidate a JPanel from another class
Javassist classes are not executed at runtime
How to use ScheduledExecutorService to run the job periodically with multiple services
How to find whether a 2D array (rectangular matrix) have a straight line

Categories

HOME
openmp
smarty
cmd
rdf
binary-tree
callback
azure-storage-tables
primary-key
alignment
windows-7-x64
ef-migrations
invantive-sql
http-status-code-504
contextmenu
nodatime
visjs
autoconf
riot.js
realex-payments-api
cas
kannel
compatibility
c++-amp
primitive
librato
gsoap
data-manipulation
oracle-fusion-middleware
vsts-build-task
http-referer
jmonkeyengine
web-mining
event-driven
abstract-class
temporary-files
elasticsearch-plugin
trim
sas-visual-analytics
turbogears
modelmapper
gpx
executenonquery
dotcover
tizen-native-app
directory-structure
flow-control
iso8601
xcb
azure-sdk
underscore.js-templating
asp.net-4.5
etsy
autorest
jwplayer7
moveit
pickadate
suffix-tree
ios4
collapse
metaclass
tmuxinator
embedded-code
0xdbe
ionic
iiviewdeckcontroller
kineticjs
dia
typekit
titanium-modules
markers
internet-connection
xojo
article
xsockets.net
ftps
shellexecute
mqx
wsdl-2.0
factory-method
mt
jquery-ui-layout
spring-portlet-mvc
hgsubversion
php-parser
telerik-scheduler
fixed-width
mediarss

Resources

Mobile Apps Dev
Database Users
javascript
java
csharp
php
android
MS Developer
developer works
python
ios
c
html
jquery
RDBMS discuss
Cloud Virtualization
Database Dev&Adm
javascript
java
csharp
php
python
android
jquery
ruby
ios
html
Mobile App
Mobile App
Mobile App