java


What is the best way to mock object instantiated inside method under test?


I have the following code and I look for the best way to test it:
public class ClientFactory {
private ConfigurationLoader loader;
public ClientFactory(ConfigurationLoader loader) {
this.loader = loader;
}
public IRest create(String something) {
Configuration config = loader.load(something);
if (magic()) {
return new ClientType1(config);
}
return new ClientType2(config);
}
}
public class ClientType1 implements IRest{
private Configuration config;
public ClientType1(Configuration config) {
this.config = config;
}
public Something doGetRequest(Long id) {
WebClient client = getHttpClient();
return client.get();
}
private WebClient getHttpClient() {
WebClient client = new WebClient();
client.setSchema(config.getSchema());
client.setHostname(config.getHostname());
client.setPort(config.getPort());
// and so on ....
return client;
}
}
I would like to test the interaction/behaviour between ConfigurationLoader and ClientType1.getHttpClient methods. From one side I think it is good idea, testing interaction between objects, from the other side, hmmm I test setters and getters - boring, no business logig is involved here. Which one is more true?
Mock of configuration object can be easily transferred into ClientType1 when it is instantiated, mocking the 'new WebClient()' seems to be the problem. I thought about:
public class ClientType1 implements IRest{
private Configuration config;
private WebClient client; // this will be replaced by mock
public ClientType1(Configuration config) {
this.config = config;
webClient = new WebClient();
}
.....
private Client getHttpClient() {
client.setSchema(config.getSchema());
....
return client;
}
}
and use PowerMock to replace private WebClient client by mock, but I am not sure it is java way. Any guidelines/suggestions?
As you have found, the new keyword makes unit testing difficult. I suggest avoiding it. I think your problem here is more of a design problem. Objects should not configure themselves. When you design an object, think about what its true dependencies are. IMO the true dependency of the ClientType1 is a WebClient or a pool of WebClient not a Configuration. IMO the true dependency of ClientFactory is a Configuration not a String.
I would redesign like so:
interface ClientFactory {
IRest create(Configuration config);
}
public class DefaultClientFactory implements ClientFactory {
private final ClientFactory magicClientFactory;
private final ClientFactory otherClientFactory;
public DefaultClientFactory(ClientFactory magicClientFactory, ClientFactory otherClientFactory) {
this.magicClientFactory = magicClientFactory;
this.otherClientFactory = otherClientFactory;
}
public IRest create(Configuration config) {
if (magic()) {
return magicClientFactory.create(config);
} else {
return otherClientFactory.create(config);
}
}
}
interface WebClientFactory {
WebClient create(Configuration config);
}
public class DefaultWebClientFactory implements WebClientFactory {
public WebClient create(Configuration config) {
WebClient client = new WebClient();
client.setSchema(config.getSchema());
client.setHostname(config.getHostname());
client.setPort(config.getPort());
return client;
}
}
public class ClientType1Factory implements ClientFactory {
private final WebClientFactory webClientFactory;
public ClientType1Factory(WebClientFactory webClientFactory) {
this.webClientFactory = webClientFactory;
}
public IRest create(Configuration config) {
return new ClientType1(webClientFactory.create(config));
}
}
public class ClientType1 implements IRest{
private final WebClient webClient;
public ClientType1(WebClient webClient) {
this.webClient = webClient;
}
public Something doGetRequest(Long id) {
return webClient.get();
}
}
Using this design you can successfully unit test each and every class defined without resorting to advanced features of PowerMock. You can unit test ClientType1 by passing in a mock WebClient. You can also test your factories by passing in different configurations and checking if the created object is what you expect. Further the code is less coupled, more flexible, and each class has a single responsibility.

Related Links

What does android:progressTintMode, android:secondaryProgressTintMode and android:progressDrawable do?
Exception in thread “main” java.lang.NoSuchMethodError: com.fasterxml.jackson.core.JsonFactory.requiresPropertyOrdering()Z
Enter multiple numbers in console
Getting file name of file being recieved on the server
Unsure about the best loop to use
Improve performance of reversing array
My Jsoup code extract elements within the first <td> tag of table only
In Java Windows Application using PdfBox Proguard zaps me
Consuming Spring Hateoas Restservice with RestTemplate
MASON Get Moore Neighbors
Java “no such element exception”
Trying to refer to a final ImageView does not work
Connect to tor with java - TorLib
Why won't this sorting work
First random number after setSeed in Java always similar
When override a method, say(), and then run the program I do not get what I anticipated to be printed

Categories

HOME
maven
cakephp
client
date
deezer
ngrx
session
getelementsbytagname
cvs
react-redux
rdf
gps
constraint-programming
portia
fancybox-3
moonmail
flux
firefox-webextensions
zapier
sylius
realex-payments-api
mmap
microsoft-r
crosstab
h2db
dynamic-featured-image
fifo
log4js-node
webkitspeechrecognition
pim
appfabric
dartium
libvpx
elasticsearch-plugin
dism
sas-visual-analytics
preconditions
unoconv
quadratic-programming
ibpy
bootstrap-dialog
google-datalayer
user-accounts
apache-fop
zip4j
dandelion
alphabet
powercli
mu
carrot
slickedit
directory-structure
flow-control
linode
word-vba-mac
google-feed-api
removechild
xml-attribute
gstreamer-0.10
simplewebrtc
ubuntu-10.04
yaws
iad
spim
thredds
dukescript
muse
appfabric-cache
mmc
geonetwork
website-monitoring
xc16
qcodo
asp.net-web-api-odata
braille
hyprlinkr
meteor-velocity
imdbpy
mysqltuner
bulkloader
factory-method
specification-pattern
selected
dice
newtonscript
buildr
code-cleanup
datareader
zend-translate
gamma
anti-piracy
commodore

Resources

Mobile Apps Dev
Database Users
javascript
java
csharp
php
android
MS Developer
developer works
python
ios
c
html
jquery
RDBMS discuss
Cloud Virtualization
Database Dev&Adm
javascript
java
csharp
php
python
android
jquery
ruby
ios
html