gerrit


What does “Reply 'Done'” conventionally mean in Gerrit?


This is not so much of a programming question as it is about the convention. What does Reply 'Done' conventionally mean as an alternative to just Reply to a comment on a code review in Gerrit?
Does it mean I agree with you and will do it or have done it locally or does it mean I have amended the change per your suggestion? Because if I amend the change and push it into the same Gerrit review, the latest file revision on which the comments are made will overwrite the previous and all the comments from before will be gone (at least that's been my experience).
The "Done" comment means that the comment has been addressed, typically by making the changes that the reviewer suggested. One normally publishes such comments after a new patch set has been pushed so that reviewers can have a new look and hopefully approve the change. Publishing the comments before the new patch set is actually available means that you'll be interrupting reviewers before there's anything new to look at.
Comments are never "gone". I don't know what you mean by that. It's perfectly okay to publish comments made on previous patch sets. Patch sets don't replace each other.

Related Links

Gerrit Replication.config
How do I give people rights in gerrit to see other people's rights
gerrit query doesn't print PL
How to prevent gerrit push to authoritative repository
what is the use refs/for/refs/* in gerrit?
How to put a local repo project into gerrit?
What is the effect of deleting a branch in gerrit
Right way to resolve gerrit “pending changes” merge conflict
Buck build failing for “events-logs” Gerrit plugin (jar)
Disable direct push and allow Gerrit push
Set “topic” of multiple patches simultaneously in gerrit
Using Gerrit to restrict read access to a git branch
Is it possible to search for commit by Change-Id in Gerrit?
Why is the gerrit change-id commit-hook not a push-hook?
LDAP changed acccount Full Name is not displaying in gerrit web page
Can I change the order of verification and code review in gerrit

Categories

HOME
bluetooth
tizen
relative-path
hashmap
routes
jira
survey
icloud
ravendb
onelogin
amazon-cloudformation
facebook-php-sdk
metatrader4
user-input
kentor-authservices
timeout
vb.net-2010
remote-access
fortumo
pugjs
visual-composer
dbext
java-3d
riot.js
tar
tapestry
android-widget
p-value
smb
xpages-ssjs
buildbot
qhull
su
kannel
entitlements
delicious-api
gsoap
socialengine
uisplitview
semantic-versioning
suricata
hot-module-replacement
splice
streamreader
elasticsearch-plugin
broadcastreceiver
businessworks
auto-update
taffy
pango
dropbox-php
rdfs
ifs
sqlbulkcopy
vtigercrm
gnome-shell-extensions
azure-virtual-network
url-masking
paypal-express
disque
bluegiga
photobucket
freelancer.com-api
natvis
sdhc
icu4j
wyam
microbenchmark
ideamart
interrupted-exception
mono-embedding
c++03
jscript.net
xojo
typeof
contenttype
seaside
transcoding
easy-install
ril
buster.js
gwt-rpc
jquery-mobile-dialog
xamlparseexception
sharp-repository
http-unit
pvrtc
mt
twrequest
dbproviderfactories
spring-portlet-mvc
semantic-diff
subscript
doh
zpt
heartbeat
xtype
xfbml
revisions
webkit.net
kdbg
ti-dsp
lzh
caching-application-block

Resources

Database Users
RDBMS discuss
Database Dev&Adm
javascript
java
csharp
php
android
javascript
java
csharp
php
python
android
jquery
ruby
ios
html
Mobile App
Mobile App
Mobile App