gerrit


What does “Reply 'Done'” conventionally mean in Gerrit?


This is not so much of a programming question as it is about the convention. What does Reply 'Done' conventionally mean as an alternative to just Reply to a comment on a code review in Gerrit?
Does it mean I agree with you and will do it or have done it locally or does it mean I have amended the change per your suggestion? Because if I amend the change and push it into the same Gerrit review, the latest file revision on which the comments are made will overwrite the previous and all the comments from before will be gone (at least that's been my experience).
The "Done" comment means that the comment has been addressed, typically by making the changes that the reviewer suggested. One normally publishes such comments after a new patch set has been pushed so that reviewers can have a new look and hopefully approve the change. Publishing the comments before the new patch set is actually available means that you'll be interrupting reviewers before there's anything new to look at.
Comments are never "gone". I don't know what you mean by that. It's perfectly okay to publish comments made on previous patch sets. Patch sets don't replace each other.

Related Links

How to specify ID when use set-reviewers
Redirect loop when connecting to Gerrit
Customize gerrit home page:logo and color
Gerrit mistakenly deleted tables Any solution?
What's the role of Change-Id in commit message
Unpublish gerrit change
how to cherry pick a patch with all its dependencies?
Purge Abandoned Change-Ids from Gerrit for good
Gerrit behaviour to find change-id in last paragraph
Gerrit Code review tool
finding out Gerrit server version when having URL
Creating folders in gerrit base path?
How to get patchset “Author” out of Gerrit?
Gerrit code/peer review data extraction
Git clone failing for gerrit repository
Gerrit to add notes to Mantis bug

Categories

HOME
ionic-framework
variables
amazon-ec2
image-processing
tinymce
react-virtualized
hashmap
lodash
gis
jgroups
google-project-tango
amazon-cloudformation
iggrid
dax
numeral.js
u-sql
apache-cayenne
n-gram
commonmark
size
dtrace
hex-editors
ups
graphlab
plunker
ml
mps
pingfederate
react-chartjs
stormpath
javascriptcore
ecto
contact-form
noraui
grails-3.1
android-kernel
android-nestedscrollview
y86
cloud-code
dosbox
dynamics-crm-2013
temporary-files
user-controls
ruby-on-rails-3.1
angular-resource
xml-documentation
filepicker
revapi
directory-structure
iso8601
objective-c-swift-bridge
elements
home-directory
actionbardrawertoggle
superstack
php-internals
rhino-servicebus
tcpserver
thredds
intellij-14
cyclomatic-complexity
purge
ionic
service-accounts
twirl
fluid-dynamics
iiviewdeckcontroller
composite
skos
python-green
knuth
tt-news
htmlcleaner
comexception
monomac
shellexecute
eventlistener
drools-planner
delphi-6
path-separator
dbproviderfactories
chrono
qtkit
removeclass
bigcouch
hamachi
xdomainrequest
yui-datatable
oncheckedchanged
visitor-statistic
digest-authentication
audio-capture
eqatec
pascal-fc

Resources

Mobile Apps Dev
Database Users
javascript
java
csharp
php
android
MS Developer
developer works
python
ios
c
html
jquery
RDBMS discuss
Cloud Virtualization
Database Dev&Adm
javascript
java
csharp
php
python
android
jquery
ruby
ios
html
Mobile App
Mobile App
Mobile App